Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: promote Tooltip, Dialog, Stack to stable #5010

Merged
merged 12 commits into from
Oct 8, 2024
Merged

feat: promote Tooltip, Dialog, Stack to stable #5010

merged 12 commits into from
Oct 8, 2024

Conversation

joshblack
Copy link
Member

@joshblack joshblack commented Sep 23, 2024 •
edited
Loading

Add Tooltip (V2), Dialog (V2), and Stack to stable entrypoint. This is a part of our v37 release.

Changelog

New

Changed

  • Add Tooltip V2 to @primer/react
  • Add Dialog V2 to @primer/react
  • Add Stack to @primer/react Apparently this was already done 😂

Removed

Rollout strategy

  • Minor release

We will remove these components from @primer/react/next and @primer/react/experimental once dotcom is migrated

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 9880ade

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Sep 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 23, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 96.73 KB (+0.03% 🔺)
packages/react/dist/browser.umd.js 96.96 KB (-0.06% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5010 September 23, 2024 18:12 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5010 October 3, 2024 14:50 Inactive
@joshblack joshblack marked this pull request as ready for review October 3, 2024 14:58
@joshblack joshblack requested a review from a team as a code owner October 3, 2024 14:58
@joshblack
Copy link
Member Author

@broccolinisoup could this go out in the next release, if possible? 🙏

@github-actions github-actions bot temporarily deployed to storybook-preview-5010 October 7, 2024 15:38 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5010 October 7, 2024 15:42 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5010 October 7, 2024 16:04 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5010 October 7, 2024 23:41 Inactive
@broccolinisoup broccolinisoup added this pull request to the merge queue Oct 8, 2024
Merged via the queue into main with commit 8385c33 Oct 8, 2024
42 checks passed
@broccolinisoup broccolinisoup deleted the feat/promote-tooltip-dialog-stack branch October 8, 2024 00:36
@primer primer bot mentioned this pull request Oct 8, 2024
Merged
@primer primer bot mentioned this pull request Oct 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@broccolinisoup broccolinisoup broccolinisoup approved these changes

@siddharthkp siddharthkp Awaiting requested review from siddharthkp siddharthkp is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshblack @broccolinisoup